Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tianmu): to adapt group by command to MySQL8.0.(#718) #721

Merged
merged 1 commit into from
Oct 14, 2022
Merged

feat(tianmu): to adapt group by command to MySQL8.0.(#718) #721

merged 1 commit into from
Oct 14, 2022

Conversation

DandreChen
Copy link
Collaborator

Summary about this PR

Issue Number: close #718

[summary]
In 5.7, group by is sorted by asc by default, but in 8.0, it is not sorted by default
Init Query_result_create::table for CTAS to fix crash

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@DandreChen DandreChen added the C-stonedb-8.0 associated with stonedb 8.0 label Oct 14, 2022
@DandreChen DandreChen self-assigned this Oct 14, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 14, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Oct 14, 2022
lujiashun
lujiashun approved these changes Oct 14, 2022
View reviewed changes
Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RingsC
RingsC suggested changes Oct 14, 2022
View reviewed changes
storage/tianmu/core/engine.cpp Outdated Show resolved Hide resolved
@DandreChen
feat(tianmu): to adapt group by command to MySQL8.0.(stoneatom#718)
509a76e 
In 5.7, group by is sorted by asc by default, but in 8.0, it is not sorted by default
Init Query_result_create::table for CTAS to fix crash
RingsC
RingsC approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 1fd190a into stoneatom:stonedb-8.0-dev Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lujiashun lujiashun lujiashun approved these changes

@RingsC RingsC RingsC approved these changes

@hustjieke hustjieke Awaiting requested review from hustjieke

@isredstar isredstar Awaiting requested review from isredstar

Assignees

@DandreChen DandreChen

Labels
C-stonedb-8.0 associated with stonedb 8.0 PR-feature feature for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DandreChen @RingsC @lujiashun